Secret detection capability #206
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Summary:
|
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Matthias Bertschy <[email protected]>
Signed-off-by: Ben <[email protected]>
matthyx
force-pushed
the
feature/secret-detection
branch
from
54d2548 to
3b6463f
Compare
|
Summary:
|
Signed-off-by: Matthias Bertschy <[email protected]>
matthyx
force-pushed
the
feature/secret-detection
branch
from
3b6463f to
397ce6a
Compare
|
Summary:
|
slashben
commented
Jan 25, 2024
Comment on lines
+151
to
+154
| fileDetectionConfig := &secretdetector.FileDetectionConfig{ | ||
| SkipBinaryFiles: false, | ||
| SizeThreshold: 0, | ||
| } |
There was a problem hiding this comment.
I'd set SkipBinaryFiles to true in the first release. We need to make the scanning more efficient before we turn this on
|
this will be implemented in node-agent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A capability that finds secrets (private key, tokens and other credential materials) in the container image and publishes it in the scan results.
Checklist before requesting a review
put an [x] in the box to get it checked