Skip to content

Improve ResourceQuota concept #50662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Improve ResourceQuota concept #50662

wants to merge 6 commits into from

Conversation

lmktfy
Copy link
Contributor

@lmktfy lmktfy commented Apr 24, 2025 •
edited
Loading

Changes that, I hope, make https://kubernetes.io/docs/concepts/policy/resource-quotas/ better [preview].

If you're a reviewer, please scroll down to find individual split-out PRs that you can review.

ℹ️ This was previously PR #50179

Tip: You might want to review this commit-by-commit and then look at the final page preview to check it all makes sense.

  • Improve the page introduction
    • Add a cautionary note that lowering ResourceQuota doesn't affect existing resource use
  • Describe the different kinds of ResourceQuota, each in their own section
  • Refactor how we describe the different kinds of ResourceQuota scope, each now in their own section
  • Reorder page sections to make better sense
  • General other tweaks
    • Use more glossary tooltips
    • mention that RBAC is not the only authz game in town
    • allow creating examples using manifests fetched via HTTP (well, HTTPS)
    • mention that ValidatingAdmissionPolicies are a thing
    • mention why it's good not to let namespace admins remove their ResourceQuotas
    • and more…
  • Add some extra links to the What's Next footer

/language en

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 24, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 24, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 24, 2025
@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch from 5581632 to e9f1adb Compare April 24, 2025 21:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 24, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5581632
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/680ab1c31d9e3a0008b0cf1a
😎 Deploy Preview https://deploy-preview-50662--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lmktfy lmktfy changed the title 20250322 improve resource quota concept Improve ResourceQuota concept Apr 24, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d46a12
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6894df62b976220008004608
😎 Deploy Preview https://deploy-preview-50662--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch from e9f1adb to cce769c Compare April 24, 2025 22:32
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 24, 2025
This was referenced Apr 24, 2025
Merged
Closed
@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch from cce769c to 540c6cb Compare April 27, 2025 21:55
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch from 540c6cb to 3f4096b Compare May 23, 2025 16:09
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2025
@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch from 3f4096b to 1334b52 Compare May 31, 2025 17:54
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2025
@lmktfy lmktfy mentioned this pull request May 31, 2025
Merged
@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch 2 times, most recently from 5c725ed to 1c8b9ad Compare June 22, 2025 15:50
@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch from 1c8b9ad to 1c7a1a8 Compare June 22, 2025 15:57
@lmktfy lmktfy mentioned this pull request Jul 29, 2025
Open
@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch from 1c7a1a8 to 92b702d Compare July 29, 2025 17:16
@lmktfy lmktfy mentioned this pull request Aug 6, 2025
Open
@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch from 92b702d to a7cffda Compare August 6, 2025 23:30
@lmktfy lmktfy force-pushed the 20250322_improve_resource_quota_concept branch from a7cffda to 2d46a12 Compare August 7, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmktfy @k8s-ci-robot