Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSONPath reference #49874

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Improve JSONPath reference #49874

merged 1 commit into from
Feb 24, 2025

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 24, 2025 •
edited
Loading

  • Add headings
  • Avoid consecutive callouts (note directly after a note)
  • Add a caption to the table
  • Misc. small alignments to docs style guide

preview

/language en

@sftim
Improve JSONPath reference
9195e20 
* Add headings
* Avoid consecutive callouts
* Add a caption to the table
* Misc. small alignments to docs style guide
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 24, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 24, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9195e20
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67bbb6934a939d0008428a40
😎 Deploy Preview https://deploy-preview-49874--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shubham82
Copy link
Contributor

Thanks @sftim
The preview looks good to me.
https://deploy-preview-49874--kubernetes-io-main-staging.netlify.app/docs/reference/kubectl/jsonpath/

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aa2afb72c485c856626051b357b47d36a48c852c

@dipesh-rawat
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 24, 2025
dipesh-rawat
dipesh-rawat reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 602a0b0 into kubernetes:main Feb 24, 2025
5 of 6 checks passed
@sftim sftim deleted the 20250223_improve_jsonpath_doc branch February 24, 2025 12:58
@windsonsea windsonsea mentioned this pull request Feb 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@reylejano reylejano Awaiting requested review from reylejano

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @Shubham82 @k8s-ci-robot @dipesh-rawat