Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Netlify configuration #49873

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix Netlify configuration #49873

merged 1 commit into from
Feb 24, 2025
+5 −5

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 23, 2025

I noticed that netlify.toml was generating TOML syntax warnings, so I made this fix.

/area web-development

@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 23, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 24, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 530460d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67bbb678632dd70008fa6e33
😎 Deploy Preview https://deploy-preview-49873--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 93268df601cee981e00170281f809a04463ba9ea

divya-mohan0209
divya-mohan0209 reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, Tim!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit e74a689 into kubernetes:main Feb 24, 2025
6 checks passed
@sftim sftim deleted the 20250223_fix_netlify_toml branch February 24, 2025 12:57
@sftim sftim mentioned this pull request Feb 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @k8s-ci-robot @dipesh-rawat @divya-mohan0209