Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: indentation for list items in reviewing-prs.md #49614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dkarczmarski
Copy link
Contributor

@dkarczmarski dkarczmarski commented Feb 1, 2025

it seems that there is an error with the indentation of two list items.

after the sentence :

- We are willing to mirror any blog article that was published to https://kubernetes.dev/blog/ (the contributor blog) provided that:

the three next points refer to that sentence,
so they should have the same indentation,
but the first one is not indented and it is the same level as the main sentence.

the second error is about the sentence starting with :

  - You should set the canonical URL for the mirrored article, to the URL of the original article

it looks like it refers to the main sentence, but it seems it should not.


EDIT: 2025-02-14

it seems that it is:

- AAA
- BBB
- CCC
- DDD1
    - DDD2
    - DDD3
    - EEE
- FFF

but should be:

- AAA
- BBB
- CCC
    - DDD1
    - DDD2
    - DDD3
- EEE
- FFF

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rayandas for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from tengqm February 1, 2025 13:52
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2025
Copy link

netlify bot commented Feb 1, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0cc2e4c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67aefb9ac93b4c0008712181
😎 Deploy Preview https://deploy-preview-49614--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2025
@dkarczmarski dkarczmarski force-pushed the fix-list-items-indentation-reviewing-prs-md branch from 1fc2ddf to 0cc2e4c Compare February 14, 2025 08:15
@nate-double-u
Copy link
Contributor

Hi @dkarczmarski, thanks for this!

Please be careful to avoid trivial edits in the future.

Here are things to consider when making minor changes:

  • Can the file be improved further?
  • Does the small change greatly enhance the quality of the content?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 30077945ff2a6f33a52d4242aab03feb72dfff2e

@dkarczmarski
Copy link
Contributor Author

Hi @dkarczmarski, thanks for this!

Please be careful to avoid trivial edits in the future.

Here are things to consider when making minor changes:

* Can the file be improved further?

* Does the small change greatly enhance the quality of the content?

/lgtm

hi @nate-double-u , I've been working on the translation into Polish language, so I read this page carefully, and that's why I found it :)

In general, an indentation changes a little bit the meaning because an indentation groups a set of points by context.
although I agree that this is a very minor change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants