-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: indentation for list items in reviewing-prs.md #49614
base: main
Are you sure you want to change the base?
fix: indentation for list items in reviewing-prs.md #49614
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
1fc2ddf
to
0cc2e4c
Compare
Hi @dkarczmarski, thanks for this! Please be careful to avoid trivial edits in the future. Here are things to consider when making minor changes:
/lgtm |
LGTM label has been added. Git tree hash: 30077945ff2a6f33a52d4242aab03feb72dfff2e
|
hi @nate-double-u , I've been working on the translation into Polish language, so I read this page carefully, and that's why I found it :) In general, an indentation changes a little bit the meaning because an indentation groups a set of points by context. |
it seems that there is an error with the indentation of two list items.
after the sentence :
the three next points refer to that sentence,
so they should have the same indentation,
but the first one is not indented and it is the same level as the main sentence.
the second error is about the sentence starting with :
it looks like it refers to the main sentence, but it seems it should not.
EDIT: 2025-02-14
it seems that it is:
but should be: