Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change X/Twitter links to Bluesky #49606

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shurup
Copy link
Member

@shurup shurup commented Jan 31, 2025

Description

This PR is heavily based on #49546 (all credits to @rikatz) to replace the Kubernetes community X/Twitter link with the one on Bluesky.

It's different from the original PR because:

  • all translation-related changes are removed (they should be implemented in separate PRs and approved by relevant localisation teams);
  • similar changes are brought to the Community page where X was mentioned as well;
  • the footer layout is slightly modified since, after adding one more social link (via Footer Social Icons #49594), 5 icons could not fit into the left column.

P.S. I'm not sure whether we're ready to merge it right now due to this comment (Bluesky accounts are not in Buffer yet).

Signed-off-by: Dmitry Shurupov <[email protected]>
@shurup shurup added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2025
Copy link

netlify bot commented Jan 31, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a2d8173
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679c7e8a0683350008089044
😎 Deploy Preview https://deploy-preview-49606--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim previously requested changes Jan 31, 2025
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

This doesn't look right though. Why has package-lock.json changed but not package.json?

@rikatz
Copy link
Contributor

rikatz commented Jan 31, 2025

Because package.json does not have any reference to font awesome :) the update was made with npm upgrade and the package.lock saved

The change is correct :)

(Also sorry for delays answering, day work has been really busy)

@sftim sftim dismissed their stale review January 31, 2025 15:14

Explanation provided

@sftim
Copy link
Contributor

sftim commented Jan 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2025
@mfahlandt
Copy link

mfahlandt commented Jan 31, 2025

Sorry to go in here again - didn't we agree in slack to deprioritize in this discussion https://kubernetes.slack.com/archives/CPNFRNLTS/p1737720949945399

In my Opinion, we should still list all of our Platforms at least in the listing site. Also proposed in the previous thread

The current decision is to still put out Content to X as it has the largest End User Audience and is growing still.
We are basically following also the decision of the CNCF there: cncf/foundation#893 (comment)

Comms created a specific rules for X https://github.com/kubernetes/community/blob/master/communication/kubernetesio-x-guidelines.md

Also as mentioned, we are still waiting for funding to automate BluSky to bufffer.

/hold

@shurup
Copy link
Member Author

shurup commented Feb 3, 2025

@mfahlandt thanks for your clarifications! Personally, I'm all in for leaving the Bluesky links only, but I'm totally fine to put the X links wherever it's needed — if that's what we need now. Thus, we're expecting the final guidance (from the Steering Committee and/or ContribEx?) here on what should be left on the website.

P.S. I guess hold did not work here, so let me do it:
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2025
@sftim
Copy link
Contributor

sftim commented Feb 5, 2025

AIUI Bluesky accounts are now in Buffer.

/committee steering
Let's confirm this is the change we want to make, at project level.

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Feb 5, 2025
@jberkus
Copy link
Contributor

jberkus commented Feb 11, 2025

Ideally, we should list everything we regularly post to, which would include BlueSky, Mastodon, X, and LinkedIn.

However, that would require some reformatting of the site footer, which doesn't currently have space for 4 icons in place of one. Particularly since we also display StackExchange, Discuss, and YouTube. At some point, we really just need to direct folks to a page listing everything.

BTW, right now the site is displaying LinkedIn in the footer.

@BenTheElder
Copy link
Member

This was formally raised to steering today, but we have not yet had time for consensus.


Personally I have been in touch with the comms team fsince this topic was first raised and I think a split between "here is a complete listing" and "here are some in the footer etc that we're prioritizing" makes sense. I think in the spirit of openness we should fully list all accounts controlled by the project somewhere if not everywhere (to avoid clutter, to prioritize preferred platforms, etc)

I also think contribex comms should have discretion here (e.g. previously bluesky got less attention due to lack of buffer support, that's a detail that should be managed by the team owning/working on this). I don't think it's pragmatic to otherwise dictate this.

This does not, however, necessarily represent the steering committee at large.


I'll make sure to follow up when we have consensus.

@sftim
Copy link
Contributor

sftim commented Feb 11, 2025

I think in the spirit of openness we should fully list all accounts controlled by the project somewhere if not everywhere (to avoid clutter, to prioritize preferred platforms, etc)

I suggest: https://www.k8s.io/community/

@shurup
Copy link
Member Author

shurup commented Feb 11, 2025

which doesn't currently have space for 4 icons in place of one

Actually, this PR modifies the footer layout already, allowing 12 (6x2) social links in the footer (instead of 8 we have right now).

I suggest: https://www.k8s.io/community/

That's a good place where all social links reside now indeed. If we want to promote some priority and not list everything everywhere, we can also consider adding a "see more" link leading to the Community page in the shorter lists (e.g. footer).

@BenTheElder
Copy link
Member

Steering has a majority consensus to support the comms team's decision here (that would be @kubernetes/contributor-comms, including @mfahlandt above).

For now then, please retain a full listing on the community page as suggested above, but we can rotate in bluesky in the footer and other places.


My suggestion: We can also iterate further in the future, with the input from @kubernetes/contributor-comms. I suggest updating with the proposed change to retain the community page, and going ahead with that. That way we can not block further on adding bluesky now that comms has those accounts in buffer, and to address the original request. We can additionally revisit how we manage the footer etc in future PRs.


Thanks all!

@sftim
Copy link
Contributor

sftim commented Feb 13, 2025

From SIG Docs, this is OK for contributor comms to unhold whenever you'd like to.

/approve
for SIG Docs. Leave the hold in place until we're ready to merge this.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@reylejano
Copy link
Member

I agree that we should list all the socials the Kubernetes project officially posts to and is active but I support any decision that Contributor Comms makes
/lgtm
Contributor Comms can unhold if ready to merge or make any other suggestions, comments, or requests for change

Copy link

@mfahlandt mfahlandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please remove the twitter widget from the bottom of the community page


[community_x_name]
other = "X (formerly Twitter)"

[community_youtube_name]
other = "YouTube"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
other = "YouTube"
other = "YouTube"
[community_twitter_name]
other = "X (formerly Twitter)"
# Also cover [community_using] if localizing this site
[community_x_name]
other = "X (formerly Twitter)"

@@ -125,11 +125,11 @@ <h2>Discussions</h2>
</div>

<div id="twitter" class="community-resource">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div id="twitter" class="community-resource">
<div id="blusky" class="community-resource">

@@ -125,11 +125,11 @@ <h2>Discussions</h2>
</div>

<div id="twitter" class="community-resource">
<a href="https://twitter.com/kubernetesio">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add this blog of twitter to the bottom of the list

@@ -257,11 +257,10 @@ no = 'Sorry to hear that. Please <a href="https://github.com/USERNAME/REPOSITORY
url = "https://www.linkedin.com/company/kubernetes/"
icon = "fa-brands fa-linkedin"

#[[params.links.user]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same re add Twitter to list as last option

@sftim
Copy link
Contributor

sftim commented Feb 20, 2025

Given #49606 (comment) and similar comments:
/lgtm cancel

Given #49606 (comment)
/hold cancel

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 20, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants