Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: Document ControlPlaneKubeletLocalMode promotion to beta #49512

Open
wants to merge 1 commit into
base: dev-1.33
Choose a base branch
from

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Jan 20, 2025

Description

This change documents the promotion of kubeadm's ControlPlaneKubeletLocalMode feature gate to beta.

/hold not sure if I should change the chinese version or if it is generated in some way or needs a separate PR to separate branch.

Issue

Part of:

Note: the following PR should merge first:

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/localization General issues or PRs related to localization labels Jan 20, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2025
@chrischdi
Copy link
Member Author

/assign @neolit123

@sftim
Copy link
Contributor

sftim commented Jan 20, 2025

not sure if I should change the chinese version or if it is generated in some way or needs a separate PR to separate branch.

Just English for this PR please.

Also, changes linked to v1.33 go in the branch dev-1.33 (main is the published documentation)

@chrischdi chrischdi changed the base branch from main to dev-1.33 January 20, 2025 16:28
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2025
Copy link

netlify bot commented Jan 20, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 77f4600
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/678e7a1f102c780007039faa
😎 Deploy Preview https://deploy-preview-49512--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2025
@chrischdi chrischdi force-pushed the pr-kubeadm-ControlPlaneKubeletLocalMode-beta branch from d2c0679 to 77f4600 Compare January 20, 2025 16:30
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 20, 2025
Copy link

netlify bot commented Jan 20, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 77f4600
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/678e7a1ec505cd000765e3b9

@sftim
Copy link
Contributor

sftim commented Jan 20, 2025

/remove-area localization
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed area/localization General issues or PRs related to localization language/zh Issues or PRs related to Chinese language labels Jan 20, 2025
@sftim
Copy link
Contributor

sftim commented Jan 20, 2025

Maintaining
/hold

for kubernetes/kubernetes#129716

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
commented on the k/k pr

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 63c3fcac7c05e412efd46ba4b97e59d156fe53c3

@neolit123
Copy link
Member

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jan 27, 2025
@neolit123
Copy link
Member

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
@neolit123
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants