-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default CoreDNS TTL #48128
base: main
Are you sure you want to change the base?
Fix default CoreDNS TTL #48128
Conversation
Now the text matches the Corefile snippet :) Ref: kubernetes/kubernetes@f7f51fa
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @simonhammes! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -112,7 +112,7 @@ The Corefile configuration includes the following [plugins](https://coredns.io/p | |||
* [kubernetes](https://coredns.io/plugins/kubernetes/): CoreDNS will reply to DNS queries | |||
based on IP of the Services and Pods. You can find [more details](https://coredns.io/plugins/kubernetes/) | |||
about this plugin on the CoreDNS website. | |||
- `ttl` allows you to set a custom TTL for responses. The default is 5 seconds. | |||
- `ttl` allows you to set a custom TTL for responses. The default is 30 seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but the default CoreDNS TTL is not 30 seconds. In other words, CoreDNS has a different default value for this field (I think it's 5 seconds).
Try this:
- `ttl` allows you to set a custom TTL for responses. The default is 30 seconds. | |
- `ttl` allows you to set a maximum time to live (TTL) for responses. The example above | |
configures CoreDNS to cache records for up to 30 seconds, even if it receives a | |
record with a longer TTL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but the default CoreDNS TTL is not 30 seconds.
I know; sorry for shortening the PR title too much. I meant default TTL when deployed through kubeadm (ref: https://github.com/search?q=repo%3Akubernetes%2Fkubernetes%20%2Fttl%20%5B%5Cd%5D%2F&type=code)
But then I completely misunderstood the current wording. My bad.
I was trying to figure out the default TTL inside a K8S cluster and thought the snippet and the text got out of sync.
How about The default configuration above [...]
?
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Description
The default TTL is 30 seconds. I fixed the explanation to match the Corefile snippet above the text.
Ref: kubernetes/kubernetes@f7f51fa