Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Localized /en/docs/contribute/review/reviewing-prs.md #39333

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[hi] Localized /en/docs/contribute/review/reviewing-prs.md #39333

wants to merge 6 commits into from

Conversation

vaibhav2107
Copy link
Member

Fixes #36512

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2023
@vaibhav2107
Copy link
Member Author

/language hi

@k8s-ci-robot k8s-ci-robot added language/hi Issues or PRs related to Hindi language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 7, 2023
@netlify
Copy link

netlify bot commented Feb 7, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cf19300
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679e2a172d4d3b00080b02f7
😎 Deploy Preview https://deploy-preview-39333--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vaibhav2107
Copy link
Member Author

Hi @anubha-v-ardhan @Babapool @bishal7679
Could you please have a look

Babapool
Babapool reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@Babapool Babapool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side, hope you find it useful. Thanks

@vaibhav2107
Copy link
Member Author

Some suggestions from my side, hope you find it useful. Thanks

Thanks @Babapool for reviewing and giving your suggestions. I will update them.

@vaibhav2107
Copy link
Member Author

@Babapool PTAL.
I have updated the PR.

Babapool
Babapool reviewed Feb 11, 2023
View reviewed changes
Copy link
Member

@Babapool Babapool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my end, hope you find them useful. Thanks.

@vaibhav2107
Copy link
Member Author

Some suggestions from my end, hope you find them useful. Thanks.

Thanks @Babapool , will update them

@vaibhav2107
Copy link
Member Author

@Babapool PTAL,
I have updated the suggestions you gave

Babapool
Babapool reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@Babapool Babapool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions from my side, hope you find them useful. Thanks

@vaibhav2107
Copy link
Member Author

@Babapool PTAL

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 15, 2023
@vaibhav2107
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 15, 2023
aj11anuj
aj11anuj suggested changes Sep 10, 2023
View reviewed changes
Copy link
Member

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggestions from me, and in often places 'PR' is written in hindi and i think that can be made better by either writing 'PR' in english or writing 'Pull Requests' in hindi.

@aj11anuj
Copy link
Member

Since, a long time there isn't any respond/activity from your side on this PR @vaibhav2107. Kindly, respond or implement changes so that this PR can either be merged or closed.

divya-mohan0209
divya-mohan0209 requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left my official review over and above Anuj's review here. @vaibhav2107 : please could you address these changes?

@vaibhav2107
Copy link
Member Author

/retest

1 similar comment
@vaibhav2107
Copy link
Member Author

/retest

@sftim
Copy link
Contributor

sftim commented May 24, 2024

/area localization

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label May 24, 2024
@tengqm
Copy link
Contributor

tengqm commented Oct 9, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tengqm
Copy link
Contributor

tengqm commented Oct 9, 2024

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

@tengqm: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@divya-mohan0209
Copy link
Contributor

@vaibhav2107 Hi! Please could you advise if you're available to work on this PR? Changes suggested ~3 months back haven't been addressed and this PR has been submitted quite some time back.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaibhav2107
Copy link
Member Author

@divya-mohan0209 I couldn't look the PR, I have done the suggested changes,,Is there anything else needed to merge this PR please let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Babapool Babapool Babapool left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 requested changes

@aj11anuj aj11anuj aj11anuj requested changes

@anubha-v-ardhan anubha-v-ardhan Awaiting requested review from anubha-v-ardhan

Assignees
No one assigned
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/hi Issues or PRs related to Hindi language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hi] Localize en/docs/contribute/review/reviewing-prs.md
8 participants
@vaibhav2107 @k8s-triage-robot @aj11anuj @sftim @tengqm @k8s-ci-robot @divya-mohan0209 @Babapool