-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial: Building a search engine on Kubernetes using Elasticsearch #28837
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have signed the CLA, just checking by changing the primary email. |
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: ee84844 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60e5bb0cbaf486000704eadd 😎 Browse the preview: https://deploy-preview-28837--kubernetes-io-main-staging.netlify.app |
@bradtopol / @zparnold - I have the same email in the CLA and commit, don't know what's wrong! |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for proposing this @aravindputrevu
It looks to me that this is documenting a specific technology (Elasticsearch). You could propose this tutorial for the Elasticsearch documentation instead; I think it would be a better fit there.
/hold
This doesn't seem to fit with the content guide
{{< note >}} | ||
The files provided in this tutorial are using GA Deployment APIs and are specific to kubernetes version 1.16 and 1.20. You can also try it on newer Kubernetes version but some APIs might throw deprecated warnings. | ||
{{< /note >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. These look like prerequisites - I'd mention them in the prerequisites section.
|
||
# Creating an Elasticsearch Cluster | ||
|
||
There are many ways to run software like Elasticsearch on Kubernetes. For example, you could use the docker images or a helm chart. I’m using the official Kubernetes operator here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no official Kubernetes operator - I'm concerned that this wording might suggest that the operator is endorsed by Kubernetes. What I think you're describing is the official Elasticsearch operator (for deploying onto Kubernetes) from Elastic.
2. Then, you will build a simple React-based search app using Kubernetes as a backend. | ||
|
||
|
||
## {{% heading "prerequisites" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many nodes do you need? The tutorial doesn't make this clear.
@sftim I was thinking that we could document about running stateful apps as elasticsearch is one. So please let me know if I need to remove anything to make it better. |
#16618 is a discussion broadly on this topic (improving on the existing stateful app tutorial). Maybe make a suggestion there? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
@aravindputrevu : Any progress on the issue/PR? |
@divya-mohan0209 I have asked the same in parent issue. I have received no update. |
@aravindputrevu: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @aravindputrevu , I agree that this PR on using Elasticsearch does not comply with the Kubernetes content guide and is better suited in the Elasticsearch documentation. I'm closing this PR but feel free to reopen this PR if you feel otherwise and we can discuss further. |
@reylejano: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm adding a tutorial in the
stateful-application
section of Kubernetes Tutorials.The tutorial explains how to build a search appliance on Kubernetes step by step with some screenshots for guidance.