-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump client-go to use golang 1.22 #33571
chore(deps): bump client-go to use golang 1.22 #33571
Conversation
The pull-client-go-build prow jobs fail at the moment because go.mod requires go >= 1.22.0 Signed-off-by: Jintao Zhang <[email protected]>
Why do we still have that job at all? We are not merging any PRs directly into the repo, so there shouldn't be anything to test? 😕 |
Typically, it's a mirror repository, eliminating the need for testing. |
I assume this does not hurt and makes this more correct, independently if we want to revisit this later /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tao12345666333: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The pull-client-go-build prow jobs fail at the moment because
go.mod requires go >= 1.22.0
xref: kubernetes/client-go#1354