Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump client-go to use golang 1.22 #33571

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

tao12345666333
Copy link
Member

The pull-client-go-build prow jobs fail at the moment because go.mod requires go >= 1.22.0

xref: kubernetes/client-go#1354

The pull-client-go-build prow jobs fail at the moment because
go.mod requires go >= 1.22.0

Signed-off-by: Jintao Zhang <[email protected]>
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Oct 2, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and sttts October 2, 2024 17:57
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2024
@pohly
Copy link
Contributor

pohly commented Oct 7, 2024

Why do we still have that job at all? We are not merging any PRs directly into the repo, so there shouldn't be anything to test?

😕

@tao12345666333
Copy link
Member Author

Typically, it's a mirror repository, eliminating the need for testing.
However, the README file solely exists in the public repo, necessitating a method to update it.

@aojea
Copy link
Member

aojea commented Oct 7, 2024

I assume this does not hurt and makes this more correct, independently if we want to revisit this later

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7b0acf3 into kubernetes:master Oct 7, 2024
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@tao12345666333: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key client-go-presubmits.yaml using file config/jobs/kubernetes/client-go/client-go-presubmits.yaml

In response to this:

The pull-client-go-build prow jobs fail at the moment because go.mod requires go >= 1.22.0

xref: kubernetes/client-go#1354

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tao12345666333 tao12345666333 deleted the fix-client-go-build branch October 8, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants