Skip to content

Conversation

soltysh
Copy link

@soltysh soltysh commented Sep 12, 2025

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This was discussed with both PRR approvers and sig-release, see this comment for all references.

Which issue(s) this PR fixes:

Fixes #2733

Special notes for your reviewer:

/assign @drewhagen

@kubernetes/sig-release-leads
@kubernetes/prod-readiness-reviewers

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-team Issues or PRs related to the release-team subproject labels Sep 12, 2025
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2025
@@ -10,6 +10,9 @@ As described by the PRR team [here](https://groups.google.com/a/kubernetes.io/g/
* It is important to note that the PRR freeze **_does not_** mean that the KEPs need to have received an approval or even a review from the PRR team by this date.
* To emphasize, the sole requirement is that all opted-in KEPs have their PRR questionnaires answered by the deadline, to ensure the PRR team has sufficient time to review them by Enhancements Freeze.

If the enhancement does not meet these requirements, it will be removed from the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on line 5 above we should also change the wording "The PRR freeze is a preliminary soft deadline"

maybe just remove "soft"?
The PRR freeze is a preliminary deadline, happening one week before the Enhancements Freeze.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@drewhagen
Copy link
Member

cc: @rayandas

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: soltysh
Once this PR has been reviewed and has the lgtm label, please ask for approval from drewhagen. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenshu
Copy link
Contributor

jenshu commented Sep 15, 2025

/lgtm but will need to resolve conflicts with @katcosgrove 's PR #2867

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@drewhagen
Copy link
Member

@soltysh are there any minor changes here that we want to rebase now that Kat's #2867 has merged?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2025
@soltysh
Copy link
Author

soltysh commented Sep 18, 2025

@soltysh are there any minor changes here that we want to rebase now that Kat's #2867 has merged?

@drewhagen rebased, so this should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request - rename PRR Freeze for 1.34
4 participants