-
Notifications
You must be signed in to change notification settings - Fork 612
Fix the restart issues with perfdash #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The perfdash pod have been restarting every few hours due to `concurrent map write`. Added a RWMutex to guard the map access
|
|
|
Welcome @matix522! |
|
Hi @matix522. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matix522, mborsz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
bug
What this PR does / why we need it:
The perfdash pod have been restarting every few hours due to
concurrent map write. Added a RWMutex to guard the map accessWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: