Add DNS lookup plugin #1080
Add DNS lookup plugin #1080
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adrianmoisey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
|
/retest |
1 similar comment
|
/retest |
| readonly KUBERNETES_SERVICE='kubernetes.default' | ||
|
|
||
| # Check getent command is present | ||
| if ! command -v getent >/dev/null; then |
There was a problem hiding this comment.
getent seems the most common tool available in a host, but do we want to use hosts or nslookup just in case getent is not available?
There was a problem hiding this comment.
I picked it since I assumed it would be the most available. I could change the logic to fall back to other tools, if getent isn't available?
May be in this order:
getenthostnslookup
There was a problem hiding this comment.
It will be good to know what install each tool in debian and red hat per example, I think gerent comes as part as libc so that makes it pretty common
There was a problem hiding this comment.
Using containers, and I don't know if that's a good idea:
Red Hat:
adrian@Adrians-MacBook-Pro:~$ docker run redhat/ubi10 getent hosts example.com
2600:1406:bc00:53::b81e:94c8 example.com
2600:1406:bc00:53::b81e:94ce example.com
2600:1408:ec00:36::1736:7f24 example.com
2600:1408:ec00:36::1736:7f31 example.com
2600:1406:3a00:21::173e:2e65 example.com
2600:1406:3a00:21::173e:2e66 example.com
adrian@Adrians-MacBook-Pro:~$ docker run redhat/ubi10 host example.com
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: exec: "host": executable file not found in $PATH
Run 'docker run --help' for more information
adrian@Adrians-MacBook-Pro:~$ docker run redhat/ubi10 nslookup example.com
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: exec: "nslookup": executable file not found in $PATH
Run 'docker run --help' for more informationDebian:
adrian@Adrians-MacBook-Pro:~$ docker run debian:latest getent hosts example.com
2600:1406:bc00:53::b81e:94c8 example.com
2600:1406:bc00:53::b81e:94ce example.com
2600:1408:ec00:36::1736:7f24 example.com
2600:1408:ec00:36::1736:7f31 example.com
2600:1406:3a00:21::173e:2e65 example.com
2600:1406:3a00:21::173e:2e66 example.com
adrian@Adrians-MacBook-Pro:~$ docker run debian:latest host example.com
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: exec: "host": executable file not found in $PATH
Run 'docker run --help' for more information
adrian@Adrians-MacBook-Pro:~$ docker run debian:latest nslookup example.com
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: exec: "nslookup": executable file not found in $PATH
Run 'docker run --help' for more information
|
LGTM |
Add a DNS lookup plugin, as per #991
I haven't done a curl yet, I just want to see if this is the right track
cc @aojea