-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrongly detecting kicbase arch as incorrect #19664
Conversation
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 52.5s 51.2s 51.1s 51.0s 53.9s Times for minikube ingress: 15.5s 16.1s 14.6s 75.5s 75.0s docker driver with docker runtime
Times for minikube start: 24.1s 24.3s 21.5s 20.4s 20.5s Times for minikube ingress: 12.8s 12.8s 12.8s 12.3s 12.3s docker driver with containerd runtime
Times for minikube start: 22.1s 20.7s 22.5s 23.8s 22.8s Times for minikube ingress: 22.8s 23.3s 38.8s 28.8s 22.8s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #19661
Before:
Specifically:
image gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 is of wrong architecture
After:
No reloading of kicabse image from cache, saves about 0.6 seconds on start.