Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrongly detecting kicbase arch as incorrect #19664

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Sep 18, 2024

Fixes #19661

Before:

I0918 11:16:50.708602   70765 lock.go:35] WriteFile acquiring /Users/powellsteven/.minikube/profiles/minikube/config.json: {Name:mk548e658760cea9905fde423ef4a820c80d6811 Clock:{} Delay:500ms Timeout:1m0s Cancel:<nil>}
W0918 11:16:50.729279   70765 image.go:95] image gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 is of wrong architecture
I0918 11:16:50.729293   70765 cache.go:149] Downloading gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 to local cache
I0918 11:16:50.729420   70765 image.go:63] Checking for gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 in local cache directory
I0918 11:16:50.729436   70765 image.go:66] Found gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 in local cache directory, skipping pull
I0918 11:16:50.729441   70765 image.go:135] gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 exists in cache, skipping pull
I0918 11:16:50.729456   70765 cache.go:152] successfully saved gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 as a tarball
I0918 11:16:50.729460   70765 cache.go:162] Loading gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 from local cache
I0918 11:16:51.443393   70765 cache.go:164] successfully loaded and using gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 from cached tarball

Specifically: image gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 is of wrong architecture

After:

0918 11:23:01.722701   71923 image.go:79] Checking for gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 in local docker daemon
I0918 11:23:01.722719   71923 preload.go:146] Found local preload: /Users/powellsteven/.minikube/cache/preloaded-tarball/preloaded-images-k8s-v18-v1.31.1-docker-overlay2-arm64.tar.lz4
I0918 11:23:01.722728   71923 cache.go:56] Caching tarball of preloaded images
I0918 11:23:01.722837   71923 preload.go:172] Found /Users/powellsteven/.minikube/cache/preloaded-tarball/preloaded-images-k8s-v18-v1.31.1-docker-overlay2-arm64.tar.lz4 in cache, skipping download
I0918 11:23:01.722850   71923 cache.go:59] Finished verifying existence of preloaded tar for v1.31.1 on docker
I0918 11:23:01.723433   71923 profile.go:143] Saving config to /Users/powellsteven/.minikube/profiles/minikube/config.json ...
I0918 11:23:01.723494   71923 lock.go:35] WriteFile acquiring /Users/powellsteven/.minikube/profiles/minikube/config.json: {Name:mk548e658760cea9905fde423ef4a820c80d6811 Clock:{} Delay:500ms Timeout:1m0s Cancel:<nil>}
I0918 11:23:01.750081   71923 image.go:98] Found gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 in local docker daemon, skipping pull
I0918 11:23:01.750101   71923 cache.go:144] gcr.io/k8s-minikube/kicbase-builds:v0.0.45-1726589491-19662@sha256:6370b9fec173944088c2d87d44b01819c0ec611a83d9e2f38d36352dff8121a4 exists in daemon, skipping load
I0918 11:23:01.750117   71923 cache.go:194] Successfully downloaded all kic artifacts

No reloading of kicabse image from cache, saves about 0.6 seconds on start.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2024
@medyagh
Copy link
Member

medyagh commented Sep 19, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 19, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19664) |
+----------------+----------+---------------------+
| minikube start | 51.9s    | 51.2s               |
| enable ingress | 39.3s    | 15.7s               |
+----------------+----------+---------------------+

Times for minikube start: 52.5s 51.2s 51.1s 51.0s 53.9s
Times for minikube (PR 19664) start: 53.0s 50.4s 52.0s 51.5s 49.2s

Times for minikube ingress: 15.5s 16.1s 14.6s 75.5s 75.0s
Times for minikube (PR 19664) ingress: 15.1s 15.0s 18.5s 15.1s 15.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19664) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 22.3s               |
| enable ingress | 12.6s    | 11.9s               |
+----------------+----------+---------------------+

Times for minikube start: 24.1s 24.3s 21.5s 20.4s 20.5s
Times for minikube (PR 19664) start: 21.9s 21.3s 23.1s 24.2s 20.7s

Times for minikube ingress: 12.8s 12.8s 12.8s 12.3s 12.3s
Times for minikube (PR 19664) ingress: 10.8s 12.8s 12.8s 10.8s 12.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19664) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 21.5s               |
| enable ingress | 27.3s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 20.7s 22.5s 23.8s 22.8s
Times for minikube (PR 19664) start: 22.6s 20.0s 22.7s 22.6s 19.6s

Times for minikube ingress: 22.8s 23.3s 38.8s 28.8s 22.8s
Times for minikube (PR 19664) ingress: 22.8s 22.8s 39.3s 22.8s 38.8s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio_arm64 (4 failed) TestMultiControlPlane/serial/RestartCluster(gopogh) 15.24% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Sep 20, 2024

/lgtm

@medyagh medyagh merged commit 0292fb5 into kubernetes:master Sep 20, 2024
34 of 49 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr deleted the fixIncorrectArchCheck branch September 25, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect architecture check for kicbase images in download/image.go
4 participants