-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect architecture check for kicbase images in download/image.go #19661
Comments
thank you @evanskinner that does seem like you are on to something ! I assume you are building a custom kicbase and then use --base-image flag? if indeed you can show me that changing that line fixes your issue, I would love you to make that PR and would be happy to merge it my only concern is that why we dont see this issue on our CI machines, since we push Kic Images on PRs and they are technically Custom image (but they are hosted in GCR instead of locally) |
Hi @evanskinner, we talked about this today and confirmed this is an issue. This doesn't impact most users since if the image if hosted in a repo it gets stored in a cache directory and even though the check you mentioned is returning false it will just load the image from the cache folder (~0.6 seconds) and continue on. But it seems in your case you're using a locally built image, which never makes its way into the cache folder and it hard fails for you. Since you've identified the issue we're more than open to you creating a PR to resolve the issue if you have the time, if not just let us know and we'll create the fix. Thanks for bringing this to our attention! |
Thanks very much for the analysis and thanks for the pointer about the cache folder. Our base image is pulled from a remote registry, using I would create the PR, but all the legal termas and conditions I have to accept to do so makes that difficult for me, sorry, |
What Happened?
When using a privately built image for kicbase, minikube fails to use it as it think it does not match the architecture of the host machine. The bug appears to be on this line
minikube/pkg/minikube/download/image.go
Line 118 in 58e7092
it reads
return cfg.Architecture == runtime.GOOS, nil
but I think it should bereturn cfg.Architecture == runtime.GOARCH, nil
Attach the log file
image.go:95] image /minikube-kicbase/kicbase:main is of wrong architecture
Operating System
Redhat/Fedora
Driver
Docker
The text was updated successfully, but these errors were encountered: