-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Demote KEP-5278 feature gates ClearingNominatedNodeNameAfterBinding and NominatedNodeNameForExpectation to Alpha #133293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd NominatedNodeNameForExpectation to Alpha Signed-off-by: utam0k <[email protected]>
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We couldn't complete it within the exception request deadline because there's one discussion topic raised at the final PR for adding an integration test.
But, we'd still love to implement this feature as an alpha feature, rather than reverting everything back. (We were originally planning to start from beta)
/lgtm
/approve
/cc @macsko
LGTM label has been added. Git tree hash: 3aad8f805c83bb9fd670096b6283c7e52c66f965
|
/approve |
/lgtm proxying @dom4ha approval, we talked offline as he is on vacation with limited connectivity |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, macsko, sanposhiho, utam0k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Vyom-Yadav to check the milestone and for visibility, since it seems there is also a exception request filed
|
cc @kubernetes/release-team-leads |
We discussed this internally and it's fine to demote this to alpha (more of required as the integration tests weren't merged). @sanposhiho @utam0k This means the the docs PR would have to be updated and the KEP readme/issue/yaml all of them as well. I'm adding this to the milestone, but open PRs for those as soon as possible. Thanks! /milestone v1.34 |
/retest |
What type of PR is this?
/kind feature
/sig scheduling
/cc sanposhiho
What this PR does / why we need it:
Demote KEP-5278 feature gates ClearingNominatedNodeNameAfterBinding and NominatedNodeNameForExpectation to Alpha.
While creating the integration test, we found that some cases had not been given sufficient consideration. To address this issue, we had to modify the design.
#133215
After discussing with @sanposhiho in Slack we decided to make this KEP Alpha.
Which issue(s) this PR is related to:
#132381
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: