Skip to content

Demote KEP-5278 feature gates ClearingNominatedNodeNameAfterBinding and NominatedNodeNameForExpectation to Alpha #133293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jul 30, 2025

What type of PR is this?

/kind feature
/sig scheduling
/cc sanposhiho

What this PR does / why we need it:

Demote KEP-5278 feature gates ClearingNominatedNodeNameAfterBinding and NominatedNodeNameForExpectation to Alpha.
While creating the integration test, we found that some cases had not been given sufficient consideration. To address this issue, we had to modify the design.
#133215

After discussing with @sanposhiho in Slack we decided to make this KEP Alpha.

Which issue(s) this PR is related to:

#132381

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Demote KEP-5278 feature gates ClearingNominatedNodeNameAfterBinding and NominatedNodeNameForExpectation to Alpha from Beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]:<https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/5278-nominated-node-name-for-expectation>

…nd NominatedNodeNameForExpectation to Alpha

Signed-off-by: utam0k <[email protected]>
@k8s-ci-robot k8s-ci-robot requested a review from sanposhiho July 30, 2025 06:50
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 30, 2025
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We couldn't complete it within the exception request deadline because there's one discussion topic raised at the final PR for adding an integration test.
But, we'd still love to implement this feature as an alpha feature, rather than reverting everything back. (We were originally planning to start from beta)

/lgtm
/approve
/cc @macsko

@k8s-ci-robot k8s-ci-robot requested a review from macsko July 30, 2025 09:28
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3aad8f805c83bb9fd670096b6283c7e52c66f965

@macsko
Copy link
Member

macsko commented Jul 30, 2025

/approve
Agree with @sanposhiho

@aojea
Copy link
Member

aojea commented Jul 30, 2025

/lgtm
/approve

proxying @dom4ha approval, we talked offline as he is on vacation with limited connectivity

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, macsko, sanposhiho, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
@aojea
Copy link
Member

aojea commented Jul 30, 2025

@Vyom-Yadav to check the milestone and for visibility, since it seems there is also a exception request filed

We couldn't complete it within the exception request deadline because there's #133215 (comment) raised at the final PR for adding an integration test.
But, we'd still love to implement this feature as an alpha feature, rather than reverting everything back. (We were originally planning to start from beta)

@pacoxu
Copy link
Member

pacoxu commented Jul 31, 2025

cc @kubernetes/release-team-leads

@Vyom-Yadav
Copy link
Member

We discussed this internally and it's fine to demote this to alpha (more of required as the integration tests weren't merged).

@sanposhiho @utam0k This means the the docs PR would have to be updated and the KEP readme/issue/yaml all of them as well. I'm adding this to the milestone, but open PRs for those as soon as possible. Thanks!

/milestone v1.34

@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 31, 2025
@macsko
Copy link
Member

macsko commented Jul 31, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9e2a0c7 into kubernetes:master Jul 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants