-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: wrong template #17717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong template #17717
Conversation
this template is referencing wrongly kubeDNS config, check the code: https://github.com/kubernetes/kops/blob/master/pkg/apis/kops/cluster.go#L107
|
Welcome @adolsalamanca! |
|
Hi @adolsalamanca. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@adolsalamanca I don't think this is quite correct. Do you mind sharing how you found this? |
|
As mentioned in the previous message, this works as intended. The template rendering is tested and, unless missing something very obvious, it is rendered correctly. |
|
/close |
|
@hakman: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
this template is referencing wrongly kubeDNS config, check the code: https://github.com/kubernetes/kops/blob/master/pkg/apis/kops/cluster.go#L107