Skip to content

azure: Allow independent VMs to join the cluster #17710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

azure: Allow independent VMs to join the cluster #17710

merged 1 commit into from
Nov 5, 2025
+216 −284

Conversation

@hakman
Copy link
Member

@hakman hakman commented Oct 25, 2025

Make it possible to experiment with Karpenter for Azure.
/hold

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 25, 2025
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2025
@hakman
Copy link
Member Author

hakman commented Oct 25, 2025

/test pull-kops-e2e-kubernetes-azure

3 similar comments
@hakman
Copy link
Member Author

hakman commented Oct 25, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman
Copy link
Member Author

hakman commented Oct 25, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman
Copy link
Member Author

hakman commented Oct 25, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman hakman requested review from ameukam and removed request for johngmyers and olemarkus October 25, 2025 08:08
@hakman
Copy link
Member Author

hakman commented Nov 4, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman
Copy link
Member Author

hakman commented Nov 4, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman
Copy link
Member Author

hakman commented Nov 4, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman hakman force-pushed the azure-karpenter branch 2 times, most recently from 008629d to 03d4ba8 Compare November 4, 2025 12:26
@hakman
Copy link
Member Author

hakman commented Nov 4, 2025

/test pull-kops-e2e-kubernetes-azure

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2025
@hakman
Copy link
Member Author

hakman commented Nov 4, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman hakman marked this pull request as ready for review November 4, 2025 20:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2025
@hakman
Copy link
Member Author

hakman commented Nov 4, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2025
@hakman
Copy link
Member Author

hakman commented Nov 4, 2025

/cc @rifelpet @ameukam
/test pull-kops-e2e-kubernetes-azure

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet November 4, 2025 20:24
@hakman
Copy link
Member Author

hakman commented Nov 4, 2025

/override pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium

In response to this:

/override pull-kops-e2e-k8s-gce-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ameukam
ameukam reviewed Nov 5, 2025
View reviewed changes
ameukam
ameukam reviewed Nov 5, 2025
View reviewed changes
pkg/nodeidentity/azure/client.go
opts := &compute.VirtualMachineScaleSetsClientGetOptions{
Expand: fi.PtrTo(compute.ExpandTypesForGetVMScaleSetsUserData),
func (c *client) getVMTags(ctx context.Context, providerID string) (map[string]*string, error) {
if !strings.HasPrefix(providerID, "azure://") {
Copy link
Member

@ameukam ameukam Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would have put "azure://" in a const given the multiple occurrences.

Copy link
Member Author

@hakman hakman Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be done for all providers, so I prefer to do it separately.

@ameukam
Copy link
Member

ameukam commented Nov 5, 2025

So existing clusters can have VMSS and independent VMs or this is a breaking change ?

@hakman
Copy link
Member Author

hakman commented Nov 5, 2025

So existing clusters can have VMSS and independent VMs or this is a breaking change ?

@ameukam Not sure I understand the Q. Existing clusters only allow VMSS, and I am adding support for VMs.
The token format changes, but will only affect new nodes.

@ameukam
Copy link
Member

ameukam commented Nov 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@hakman
Copy link
Member Author

hakman commented Nov 5, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit f058835 into kubernetes:master Nov 5, 2025
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rifelpet rifelpet Awaiting requested review from rifelpet

1 more reviewer

@ameukam ameukam ameukam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ameukam ameukam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

3 participants

@hakman @k8s-ci-robot @ameukam