Mark NEGs from removed subnets at TO_BE_DELETED #2807
Merged
+401
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
swetharepakula
force-pushed
the
mark-tbd-neg
branch
from
a0c824e to
314e96b
Compare
k8s-ci-robot
added
size/L
* tests are refactored to incorporate NodeTopology CR * checkNEGCRWithParams generates and validates NEGs in deleted subnets * Add comments and pull out logic into helper methods to make unit tests clearer
swetharepakula
force-pushed
the
mark-tbd-neg
branch
from
314e96b to
9b8c540
Compare
k8s-ci-robot
added
size/XL
* NEGs that exists but the subnet does not in the NodeTopology CR will be marked as TO_BE_DELETED * NEG Obj references that do not have SubnetworkURL set are considered to be part of the default subnet
swetharepakula
force-pushed
the
mark-tbd-neg
branch
from
9b8c540 to
1bb6717
Compare
|
Looks great! Thanks. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @gauravkghildiyal