-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-5425 Automatic Swap Labels #5426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ajaysundark
commented
Jun 20, 2025
- One-line PR description: Kubelet creates preset label for swap enabled nodes.
- Issue link: Automatic Swap Node Labels #5425
- Other comments:
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ajaysundark The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ajaysundark: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[kubernetes/kubernetes]: https://git.k8s.io/kubernetes | ||
[kubernetes/website]: https://git.k8s.io/website | ||
|
||
## Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it needed upstream if there will be #5424?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not aware of #5424. I'd discuss with them to understand their approach further.
But, the interest of labels is not to solve all of swap-scheduling.
IMHO, Labels offer node-filtering for swap-enabled nodes for node-management tasks such as selective tainting or targeted node-selection for auto-scaling (eg: setting additional rules for HPA). This visibility will also benefit better monitoring of swap-nodes.