Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixing redirects from docs/user-guide which were removed in website repo #9851

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

panyam
Copy link
Contributor

@panyam panyam commented Jan 13, 2025

Fixes #20233

docs/user-guide redirects were removed in kubernetes/website@b832ead

Cleaning up these redirects from dashboard as well.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @panyam!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.88%. Comparing base (2e588c6) to head (693562f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9851   +/-   ##
=======================================
  Coverage   35.88%   35.88%           
=======================================
  Files         301      301           
  Lines       14503    14503           
  Branches      202      183   -19     
=======================================
  Hits         5204     5204           
  Misses       9075     9075           
  Partials      224      224           

@panyam panyam changed the title Fixing redirects from docs/user-guide which were removed in website repo docs: Fixing redirects from docs/user-guide which were removed in website repo Jan 14, 2025
@panyam
Copy link
Contributor Author

panyam commented Jan 15, 2025

Hey @maciaszczykm Can you please take a look again - Ive updated the title but am unable to add the kind/documentation label to this (my label field seems to be uneditable). Thanks in advance.

@panyam panyam requested a review from maciaszczykm January 15, 2025 06:44
@maciaszczykm maciaszczykm added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 15, 2025
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, panyam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 31f5d62 into kubernetes:master Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants