Update running-locally.md sudo example to preserve $PATH

[ostrain]

Tiny change to make the local-up-cluster.sh sudo example preserve $PATH to ensure etcd is available

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ostrain
Once this PR has been reviewed and has the lgtm label, please assign cblecker for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• contributors/devel/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @ostrain!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ostrain. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pacoxu]

/ok-to-test

[BenTheElder]

/sig testing
/cc @pohly

[BenTheElder]

this can also break users, imagine if they only have docker available to root (which is why we need to sudo) ... this is dependent on users and their local path manipulation ...

what was missing from PATH in your case?

[ostrain]

etcd was missing -- if one follows the instructions earlier on the page to install etcd, it gets installed in such a way that you have to manually add it to your $PATH

[BenTheElder]

Ah, I think we should probably update the script to find etcd in the expected install location in addition to $PATH.

[pohly]

I wasn't aware that the instructions say sudo ./hack/local-up-cluster.sh. I always invoke it as normal user (./hack/local-up-cluster.sh) and it internally prefixes some commands with sudo as needed.

My PATH includes etcd, because that is also needed for other commands (go test ./test/integration/<something>).

[BenTheElder]

My PATH includes etcd, because that is also needed for other commands (go test ./test/integration/).

Well, the integration scripts actually handle this for you now :-)

We could have the go targets do it too, it will just be messier.

but either way, if you run with sudo at the top level your path will not be preserved

we should probably stop specifying sudo here entirely

[ostrain]

Did a little more testing and I confirmed that it works without sudo for me.

I figured out why I thought I needed the sudo workaround though: after I've run the script once, before I can run it again I have to manually delete /var/run/kubernetes/* and the relevant /tmp/*.log files or it fails to come up -- it looks like it's because a smattering of these files end up owned by root which breaks things.