VPA - Update release instructions for automatically built images #8081
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
size/M
raywainman
force-pushed
the
vpa-release-instructions
branch
2 times, most recently
from
c400911 to
2950b1f
Compare
raywainman
force-pushed
the
vpa-release-instructions
branch
from
2950b1f to
c6ce144
Compare
adrianmoisey
reviewed
May 2, 2025
|
|
||
| ```sh | ||
| cd vertical-pod-autoscaler/ | ||
| TAG=`grep 'const versionCore = ' common/version.go | cut -d '"' -f 2` |
There was a problem hiding this comment.
I wonder if it makes sense to echo $BUILD_TAG and $TAG just to show the operator what's happening?
Suggested change
| TAG=`grep 'const versionCore = ' common/version.go | cut -d '"' -f 2` | |
| TAG=`grep 'const versionCore = ' common/version.go | cut -d '"' -f 2` | |
| echo "Adding tag $TAG based on built tag $BUILD_TAG" |
|
/lgtm Left comment, so will hold: Your choice if it needs addressing or not |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Update the release instructions to make use of the automatically built images as part of #7902.
Does this PR introduce a user-facing change?