-
Notifications
You must be signed in to change notification settings - Fork 4.1k
VPA: Per-node recommendations (very early draft) #7978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Record the node name as an extra label on each pod, then extract it when writing the recommendation. Inside the admission-controller we recognize which node the pod will run on by unpacking nodeAffinity. Signed-off-by: Bryan Boreham <[email protected]>
Skipping CI for Draft Pull Request. |
@bboreham Thanks for starting this! Can you give me a ping once this is in a state where you think it is mostly doing what it should do? |
For future reference: with the current state, the VPA
So for clusters with a big number of nodes the status grows quite a lot. |
Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bboreham The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
This is a very early draft in pursuit of AEP-7942.
Adds an optional field
scope
on the VPA object, to let the VPA components generate and update more fine-grained recommendations.Only one value of
scope
is implemented by this PR:node
.If this is set, record the node name as an extra label on each pod, then extract it when writing the recommendation.
Inside the admission-controller we recognize which node the pod will run on by unpacking nodeAffinity.
Special notes for your reviewer:
The change to
version.go
is intended as temporary while testing, not intended to be merged.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
AEP-7942