-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Detect no matching resources #5917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Detect no matching resources #5917
Conversation
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adoramshoval The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @adoramshoval! |
Hi @adoramshoval. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
resolved conflicts
…nsformer This commit makes use of the new PatchArgs type and the new Patch option `allowNoTargetMatch`. This option, if true, allows rendering kustomization even if no resource is matched against the given target, while printing a warning to stderr. By default this option is set to false meaning that if no resource is matched against the given target an error is raised. This commit includes the extra tests to test this new feature.
d88131f
to
015d04b
Compare
This PR aims to resolve the rotten issue no. #4379 .
As #4715 has rotten as well, this PR is continuing the contributor (@laxmikantbpandhare ) work maintaining the already existing commits.
This PR adds the enforcement for resources selectors not matching any resources at all by throwing an error if no resource has been selected.
A new option has been added,
allowNoTargetMatch
, allowing to avoid this error, which will cause a warning to be printed and resources to rendered if no further error is encountered.The
Options
attribute has been replaced from amap[string]bool
to a newtype
under theapi
directory namedPatchArgs
. This will provide a better documentation and will help to avoid typing errors.NOTE: The changes done in this PR have been requested in the PR mentioned above by @annasong20 .