-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kube-router config generation #5531
Fix kube-router config generation #5531
Conversation
/assign @riverzhang Maybe @bozzo would also be interested by this PR as he his listed as a maintainer of the kube-router deployment in #5432. I am not sure if I need to assign him to this PR though... |
@MrFreezeex Good Job! It will be easier to update Kube-Router config |
27a2c56
to
7fecbd6
Compare
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
7fecbd6
to
75e802f
Compare
I refactor a lot of my code because kube-router can write into the cni config (updating the subnet), and my previous attempt would overwrite those changes. I fixed this by allowing the subnet in the cni config to be overwritten by the one retrieved from the host. I have no more modification to do on this PR, let me know if further changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @MrFreezeex and @bozzo for getting this moving! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miouge1, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
The cni config and the kubeconfig were not updated on a new deployment of the playbook.
The apiserver ip in the kubeconfig was sometimes incorrect.
This PR solves those two issues by generating those two files with ansible instead of relying on a configmap and an initContainer deployed on the first master.
See the issue for more details about it.
Which issue(s) this PR fixes:
Fixes #5530
Special notes for your reviewer:
Does this PR introduce a user-facing change?: