Repository navigation
Add flowtable counter support - #47
kubernetes-prow[bot] merged 1 commit into
Conversation
Lets callers keep conntrack accounting up to date for offloaded flows.
kubernetes-prow
Bot
added
size/M
|
|
||
| // nft add flowtable inet example_table example_flowtable { hook ingress priority filter ; devices = { eth0 }; } | ||
| // nft add flowtable inet example_table example_flowtable { hook ingress priority filter ; devices = { eth0 } ; counter ; } | ||
| // Every property is optional, so a flowtable may have a counter and no devices. |
There was a problem hiding this comment.
Is that true? The man page claims devices is required.
Though, I guess, my nft man page doesn't mention flowtable counters...
There was a problem hiding this comment.
Yep! At least in my local verification, I was able to create tables without devices but with counter set. Not sure why that would be useful, though.
|
|
||
| // Counter enables packet and byte accounting for offloaded flows. | ||
| // (Optional; requires kernel 5.13 or later) | ||
| Counter *bool |
There was a problem hiding this comment.
How do you read the counter?
There was a problem hiding this comment.
The flowtable counter just indicates that conntrack metrics should continue to be updated based on the offloaded flows (whereas normally they are not) - so we read them from there.
|
I was going to say "you need to update /lgtm |
kubernetes-prow
Bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caseydavenport, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
2 participants
Hopefully not contentious!
We're getting around to flowtable support in Calico, and would like access to counter metrics for offloaded flows.