-
Notifications
You must be signed in to change notification settings - Fork 377
Added env var config to plugin manager #3526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added env var config to plugin manager #3526
Conversation
Signed-off-by: Yannick Wahner <[email protected]>
Signed-off-by: Yannick Wahner <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nabsku The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Nabsku! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for configuring the plugin manager via environment variables by updating Helm chart defaults and templates.
- Introduces a commented-out
env
block invalues.yaml
for users to specify plugin manager env vars. - Updates the deployment template to render
.Values.pluginsManager.env
under the container spec.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
charts/headlamp/values.yaml | Added instructions for setting pluginsManager.env |
charts/headlamp/templates/deployment.yaml | Injects env: entries from .Values.pluginsManager.env |
Comments suppressed due to low confidence (2)
charts/headlamp/templates/deployment.yaml:264
- Wrap the
env:
block in a Helm conditional (e.g.,{{- if .Values.pluginsManager.env }}
) so it’s only rendered when env vars are defined. This prevents Helm from emittingnull
or an empty block when users don’t specify any env entries.
env:
charts/headlamp/values.yaml:247
- Provide a default empty array for
pluginsManager.env
(e.g.,env: []
) in the values file instead of only a commented example. This ensurestoYaml
always produces a valid list and avoids renderingnull
.
# env:
Just to address the two low confidence comments: I decided not to do that and follow the existing conventions in the pluginManager (see |
Summary
This PR adds the ability to configure the plugin manager via env vars. This allows the user to set a proxy or even set npm settings like the registry.
Changes
Steps to Test