Skip to content

frontend: redux: uiSlice tests #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DhairyaMajmudar
Copy link
Contributor

Description

Add unit test cases for uiSlice reducer

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DhairyaMajmudar
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2025
@illume illume requested a review from Copilot June 16, 2025 06:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive unit tests for the uiSlice reducer in the frontend Redux module.

  • Adds tests for initial state handling and for each action, including toggle actions and UI panel addition/replacement.
  • Verifies that state transitions occur as expected using defined test components and functions.
Comments suppressed due to low confidence (1)

frontend/src/redux/uiSlice.test.ts:18

  • [nitpick] The import alias 'uiSliceObject' can be renamed (for example, to 'uiSliceActions') to more clearly differentiate between the default reducer and its associated actions, improving code clarity.
import uiSlice, { uiSlice as uiSliceObject } from './uiSlice';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants