Break dependency on k/k and remove replace statements in go.mod file #932
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
amacaskill
force-pushed
the
break-dep
branch
2 times, most recently
from
d7bded9 to
0bd90c1
Compare
|
/assign @msau42 |
|
/test pull-gcp-filestore-csi-driver-e2e |
2 similar comments
|
/test pull-gcp-filestore-csi-driver-e2e |
|
/test pull-gcp-filestore-csi-driver-e2e |
| k8s.io/sample-cli-plugin => k8s.io/sample-cli-plugin v0.26.0 | ||
| k8s.io/sample-controller => k8s.io/sample-controller v0.26.0 | ||
| ) | ||
| replace k8s.io/client-go => k8s.io/client-go v0.26.0 |
There was a problem hiding this comment.
I think even this can be removed
There was a problem hiding this comment.
I don't think it can. I was running into this issue
There was a problem hiding this comment.
Can you try setting 0.26.0 in L32?
There was a problem hiding this comment.
Changing to 0.26.0 and removing the replace statement results in
go: sigs.k8s.io/gcp-filestore-csi-driver/pkg/client/clientset/versioned imports
k8s.io/client-go/util/flowcontrol imports
k8s.io/apimachinery/pkg/util/clock: module k8s.io/apimachinery@latest found (v0.31.0), but does not contain package k8s.io/apimachinery/pkg/util/clock
go: sigs.k8s.io/gcp-filestore-csi-driver/pkg/csi_driver imports
k8s.io/client-go/informers imports
k8s.io/api/auditregistration/v1alpha1: module k8s.io/api@latest found (v0.31.0), but does not contain package k8s.io/api/auditregistration/v1alpha1
go: sigs.k8s.io/gcp-filestore-csi-driver/pkg/csi_driver imports
k8s.io/client-go/informers imports
k8s.io/api/batch/v2alpha1: module k8s.io/api@latest found (v0.31.0), but does not contain package k8s.io/api/batch/v2alpha1
go: sigs.k8s.io/gcp-filestore-csi-driver/pkg/csi_driver imports
k8s.io/client-go/informers imports
k8s.io/api/settings/v1alpha1: module k8s.io/api@latest found (v0.31.0), but does not contain package k8s.io/api/settings/v1alpha1
go: sigs.k8s.io/gcp-filestore-csi-driver/pkg/webhook imports
sigs.k8s.io/controller-runtime/pkg/certwatcher tested by
sigs.k8s.io/controller-runtime/pkg/certwatcher.test imports
sigs.k8s.io/controller-runtime imports
sigs.k8s.io/controller-runtime/pkg/builder imports
sigs.k8s.io/controller-runtime/pkg/client imports
k8s.io/client-go/metadata: package k8s.io/client-go/metadata provided by k8s.io/client-go at latest version v0.31.0 but not at required version v11.0.1-0.20190805182717-6502b5e7b1b5+incompatible
I also tried v0.31.0, but it keeps saying it wants k8s.io/client-go/metadata at v11.0.1-0.20190805182717-6502b5e7b1b5+incompatible
There was a problem hiding this comment.
bummer, this is still a good improvement though so let's go with what we have for now
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR allows us to remove most of the replace statements in go.mod. The client-go replace statement was still needed in order for go mod tidy to succeed. See details here
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: