Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update maintainers/reviewers #5020

Merged
merged 2 commits into from
Feb 18, 2025
Merged

chore: update maintainers/reviewers #5020

merged 2 commits into from
Feb 18, 2025

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Jan 20, 2025 •
edited
Loading

Description

add @ivankatliarchuk to list of maintaners/reviewers

Checklist

  • Unit tests updated
  • End user documentation updated

@ivankatliarchuk
chore: update maintainers/reviewers
141e05f 
Signed-off-by: ivan katliarchuk <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2025
@mloiseleur
Copy link
Contributor

Thanks @ivankatliarchuk for all your recent contributions on external-dns

The official guide says about requirements for reviewer:

  • Primary reviewer for at least 5 PRs to the codebase
  • Reviewed or merged at least 20 substantial PRs to the codebase

We are half the way here, so let's just wait a bit longer. You can already lgtm PR, so there is no need to rush.

@ivankatliarchuk
Copy link
Contributor Author

Yeah, I get that. Actually added a proposal to update this document ;-) kubernetes/community#8292

@ivankatliarchuk
Copy link
Contributor Author

And this one cncf/devstats#91

@ivankatliarchuk
Copy link
Contributor Author

I'll close this for now. Let's re-open if when/required

/close

@k8s-ci-robot
Copy link
Contributor

@ivankatliarchuk: Closed this PR.

In response to this:

I'll close this for now. Let's re-open if when/required

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivankatliarchuk
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

@ivankatliarchuk: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mloiseleur
Copy link
Contributor

@ivankatliarchuk Now that #5099 is merged, CI should go green. Would you please rebase it ?

@ivankatliarchuk
Merge branch 'master' into chore-update-reviewers
24c0056 
* master: (97 commits)
  chore(formatting): fix infected files with correct formatting (kubernetes-sigs#5099)
  docs: Fix managed-record-type argument
  docs(proposal): support multiple replicas with leader election (kubernetes-sigs#5051)
  feat(chart): automate helm json schema (kubernetes-sigs#5075)
  docs(proposal): update proposal template, add statuses
  test(aws): introduce first fixture-based (kubernetes-sigs#5092)
  chore(makefile): add helper and document targets
  feat: Updated chart for v1.15.2 release
  chore(makefile): add helper and document targets
  chore(filter-tags): pre-process filter tags
  chore(filter-tags): pre-process filter tags
  chore(filter-tags): pre-process filter tags
  chore(deps): bump the dev-dependencies group across 1 directory with 21 updates
  test(domain-filter): simple filters on domain exclusion (kubernetes-sigs#5064)
  chore(deps): bump nosborn/github-action-markdown-cli
  ci(docs): add markdown linters and editorconfig (kubernetes-sigs#5055)
  Address PR comments
  docs: update and refactor contribution part (kubernetes-sigs#5073)
  fix(chart): update rbac for F5 transportserver source (kubernetes-sigs#5066)
  fix(chart): non-string types on svcaccount annotations (kubernetes-sigs#5067)
  ...
@ivankatliarchuk
Copy link
Contributor Author

done

@szuecs
Copy link
Contributor

szuecs commented Feb 18, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@mloiseleur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 22762d8 into kubernetes-sigs:master Feb 18, 2025
13 checks passed
@szuecs
Copy link
Contributor

szuecs commented Feb 18, 2025

Welcome @ivankatliarchuk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivankatliarchuk @mloiseleur @k8s-ci-robot @szuecs