Skip to content

Conversation

troy0820
Copy link
Member

Instead of saying use latest which can have a different go version in the go.mod at the time of reading the doc, we can just use the last release.

If people want to install at latest, they will do so at their own will.

Fixes #3358

/assign @sbueringer
/assign @alvaroaleman

Not sure if this is sufficient but it does document this a little better than before.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 16, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2025
@troy0820 troy0820 changed the title 📖Remove @latest from setupenvtest docs 📖Remove latest from setupenvtest docs Oct 16, 2025

```shell
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to instead tell ppl to download it from a github release to avoid keeping this up to date? We will most likely forget to do that

Copy link
Member

@sbueringer sbueringer Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's point to the GitHub release first and then mention this with release-major.minor or some other placeholder

Signed-off-by: Troy Connor <[email protected]>
@troy0820 troy0820 force-pushed the troy0820/update-setup-envtest-doc branch from e5b6e56 to e132b97 Compare October 17, 2025 17:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: troy0820
Once this PR has been reviewed and has the lgtm label, please ask for approval from alvaroaleman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

sbueringer commented Oct 20, 2025

/lgtm

I'm fine with mentioning a release branch. I would see this only as an example that we don't have to keep up to date

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4b0c3f2b4caeb362683d4aa5ab77b4fb72e916f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup-envtest@latest requires golang >=1.25.0?

4 participants