-
Notifications
You must be signed in to change notification settings - Fork 1.2k
📖Remove latest from setupenvtest docs #3359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
📖Remove latest from setupenvtest docs #3359
Conversation
|
||
```shell | ||
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest | ||
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@release-0.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to instead tell ppl to download it from a github release to avoid keeping this up to date? We will most likely forget to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's point to the GitHub release first and then mention this with release-major.minor or some other placeholder
Signed-off-by: Troy Connor <[email protected]>
e5b6e56
to
e132b97
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: troy0820 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm I'm fine with mentioning a release branch. I would see this only as an example that we don't have to keep up to date |
LGTM label has been added. Git tree hash: 4b0c3f2b4caeb362683d4aa5ab77b4fb72e916f6
|
Instead of saying use
latest
which can have a different go version in the go.mod at the time of reading the doc, we can just use the last release.If people want to install at latest, they will do so at their own will.
Fixes #3358
/assign @sbueringer
/assign @alvaroaleman
Not sure if this is sufficient but it does document this a little better than before.