🐛 Update object upon deletion

[bigkevmcd]

If an object is deleted and the API responds with a resource, update the deleted object.

This causes the object to be updated with the deletion timestamp.

The fake Client was already behaving like this.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigkevmcd
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @bigkevmcd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alvaroaleman]

/ok-to-test

[alvaroaleman]

/ok-to-test

[alvaroaleman]

Thanks, this is great! We also need to update the fake client to match the behavior

[alvaroaleman]

Can we also test this with unstructured.Unstructured and metav1.MetaObject, please?

[bigkevmcd]

Unstructured works... metav1.MetaObject will require a fair bit more work.

controller-runtime/pkg/client/metadata_client.go

Line 67 in c5bb1d4

return resInt.Delete(ctx, metadata.Name, *deleteOpts.AsDeleteOptions())

Not sure if this is relevant?

controller-runtime/pkg/client/metadata_client.go

Line 30 in c5bb1d4

// TODO(directxman12): we could rewrite this on top of the low-level REST

[bigkevmcd]

Thanks, this is great! We also need to update the fake client to match the behavior

My reading of this test is that the fake client does actually work?

controller-runtime/pkg/client/fake/client_test.go

Line 817 in c5bb1d4

Expect(obj.DeletionTimestamp).NotTo(BeNil())

[alvaroaleman]

That example is after a Get call, it should be set after a Delete call

[sbueringer]

/assign