🐛 upgrade golangci-lint to v1.61.0 #2950
Open
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sivchari <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sivchari The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
sivchari
changed the title
sivchari
force-pushed
the
upgrade-golangci
branch
from
409f39c
to
469e9d1
Compare
k8s-ci-robot
added
size/S
sivchari
force-pushed
the
upgrade-golangci
branch
from
469e9d1
to
539b43b
Compare
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
upgrade-golangci
branch
from
539b43b
to
c487124
Compare
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
upgrade-golangci
branch
from
b497534
to
e96da8a
Compare
| @@ -1544,7 +1544,7 @@ func CacheTest(createCacheFunc func(config *rest.Config, opts cache.Options) (ca | |||
| return obtainedPodNames | |||
| }, ConsistOf(tc.expectedPods))) | |||
| for _, pod := range obtainedStructuredPodList.Items { | |||
| Expect(informer.Get(context.Background(), client.ObjectKeyFromObject(&pod), &pod)).To(Succeed()) //nolint:gosec // We don't retain the pointer | |||
| Expect(informer.Get(context.Background(), client.ObjectKeyFromObject(&pod), &pod)).To(Succeed()) // We don't retain the pointer | |||
There was a problem hiding this comment.
Can delete the entire comments for these, the purpose of the comment was to explain the nolint directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgade the golangci-lint version to v1.61.0.