Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove deprecated kube-apiserver cloud-provider arg #5443

Merged
merged 2 commits into from
Feb 24, 2025
Merged

fix: remove deprecated kube-apiserver cloud-provider arg #5443

merged 2 commits into from
Feb 24, 2025

Conversation

willie-yao
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This is a test PR with no changes to test conformance tests

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 20, 2025
@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.41%. Comparing base (0f04d8d) to head (0aba8bc).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5443   +/-   ##
=======================================
  Coverage   52.41%   52.41%           
=======================================
  Files         272      272           
  Lines       29361    29361           
=======================================
  Hits        15390    15390           
  Misses      13165    13165           
  Partials      806      806

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willie-yao
Copy link
Contributor Author

/retest

@willie-yao
Copy link
Contributor Author

/pull-cluster-api-provider-azure-conformance-custom-builds
/pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
/pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
/pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra

@willie-yao
Copy link
Contributor Author

/test ls

@k8s-ci-robot
Copy link
Contributor

@willie-yao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-azure-apiversion-upgrade

/test pull-cluster-api-provider-azure-build

/test pull-cluster-api-provider-azure-ci-entrypoint

/test pull-cluster-api-provider-azure-e2e

/test pull-cluster-api-provider-azure-e2e-aks

/test pull-cluster-api-provider-azure-test

/test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-azure-apidiff

/test pull-cluster-api-provider-azure-apiserver-ilb

/test pull-cluster-api-provider-azure-capi-e2e

/test pull-cluster-api-provider-azure-conformance

/test pull-cluster-api-provider-azure-conformance-custom-builds

/test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts

/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra

/test pull-cluster-api-provider-azure-e2e-optional

/test pull-cluster-api-provider-azure-e2e-workload-upgrade

/test pull-cluster-api-provider-azure-load-test-custom-builds

/test pull-cluster-api-provider-azure-windows-custom-builds

/test pull-cluster-api-provider-azure-windows-with-ci-artifacts

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-azure-apidiff

pull-cluster-api-provider-azure-apiversion-upgrade

pull-cluster-api-provider-azure-build

pull-cluster-api-provider-azure-e2e

pull-cluster-api-provider-azure-e2e-aks

pull-cluster-api-provider-azure-test

pull-cluster-api-provider-azure-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-conformance
/test pull-cluster-api-provider-azure-conformance-custom-builds
/test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra
/test pull-cluster-api-provider-azure-ci-entrypoint

@willie-yao willie-yao mentioned this pull request Feb 20, 2025
Closed
@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-conformance
/test pull-cluster-api-provider-azure-conformance-custom-builds
/test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra
/test pull-cluster-api-provider-azure-ci-entrypoint

@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-conformance
/test pull-cluster-api-provider-azure-conformance-custom-builds
/test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra
/test pull-cluster-api-provider-azure-ci-entrypoint

@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-conformance
/test pull-cluster-api-provider-azure-conformance-custom-builds
/test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra
/test pull-cluster-api-provider-azure-ci-entrypoint

@willie-yao
Copy link
Contributor Author

/retest

1 similar comment
@willie-yao
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 22, 2025
@willie-yao willie-yao changed the title WIP: [DO_NOT_MERGE] Test conformance fix: remove deprecated kube-apiserver cloud-provider arg Feb 22, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 22, 2025 •
edited
Loading

@willie-yao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apiversion-upgrade 50170d6 link true /test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra 0aba8bc link false /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jackfrancis
Copy link
Contributor

/test pull-cluster-api-provider-azure-load-test-custom-builds

jsturtevant
jsturtevant approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9cd4aeddf9844546674bc5a986222de6729d4d00

mboersma
mboersma approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6967dce into kubernetes-sigs:main Feb 24, 2025
32 of 33 checks passed
@jsturtevant jsturtevant mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@jsturtevant jsturtevant jsturtevant approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@mboersma mboersma

@jsturtevant jsturtevant

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@willie-yao @k8s-ci-robot @jackfrancis @mboersma @jsturtevant