Bump CAPI to v1.9.4

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.9.4.

Which issue(s) this PR fixes:

Fixes #5290
Closes #5384

Special notes for your reviewer:

See controller-runtime v0.19 release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.19.0
See CAPI 1.8 - 1.9 migration guide: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md
CAPA's PR, for comparison: kubernetes-sigs/cluster-api-provider-aws#5209

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Bump CAPI to v1.9.3

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint

[codecov]

Codecov Report

Attention: Patch coverage is 31.11111% with 62 lines in your changes missing coverage. Please review.

Project coverage is 52.40%. Comparing base (b026094) to head (ebf4bd4).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
main.go	0.00%	18 Missing ⚠️
...ntrollers/azureasomanagedmachinepool_controller.go	0.00%	9 Missing ⚠️
controllers/azureasomanagedcluster_controller.go	0.00%	8 Missing ⚠️
...trollers/azureasomanagedcontrolplane_controller.go	0.00%	7 Missing ⚠️
controllers/asosecret_controller.go	0.00%	5 Missing ⚠️
controllers/azurejson_machine_controller.go	0.00%	3 Missing ⚠️
controllers/azurejson_machinepool_controller.go	0.00%	3 Missing ⚠️
...ontrollers/azurejson_machinetemplate_controller.go	0.00%	3 Missing ⚠️
azure/scope/machine.go	0.00%	1 Missing ⚠️
azure/scope/machinepool.go	0.00%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5316      +/-   ##
==========================================
- Coverage   52.44%   52.40%   -0.04%     
==========================================
  Files         272      272              
  Lines       29349    29361      +12     
==========================================
- Hits        15391    15388       -3     
- Misses      13152    13167      +15     
  Partials      806      806              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint
/test pull-cluster-api-provider-azure-verify

[willie-yao]

This may have Skipped the rest of the neighboring test suite--it's tricky getting Ginkgo's container nesting right, maybe adding an It here wasn't enough. I need to investigate and maybe just comment out this spec.

I just manually commented it out. I remember doing this for previous e2e tests we have skipped. Would it be sufficient to just comment it out instead of using Skip?

[mboersma]

/hold cancel

Commented out test spec instead.

[willie-yao]

/lgtm

cc @nawazkh for approval

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1ed432d8d76b459fa1e8811521a22264deec64c6

[willie-yao]

/test pull-cluster-api-provider-azure-e2e-optional

[nawazkh]

/lgtm
/approve

This was a fun-debug-ride!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nawazkh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nawazkh]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 02119a53f70a11114cd373b5dc5a40854497ec74

[k8s-ci-robot]

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apidiff	ebf4bd4	link	false	/test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.