-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace most usage of go-autorest in unit tests #4447
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4447 +/- ##
=======================================
Coverage 61.95% 61.95%
=======================================
Files 188 188
Lines 18768 18768
=======================================
Hits 11628 11628
Misses 6502 6502
Partials 638 638 ☔ View full report in Codecov by Sentry. |
Data race condition detected in two unit tests: will fix. |
ca21e9d
to
a97f872
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 170d774a5063c226931bc83f8bde5ec59b0b4446
|
a97f872
to
ce24d80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 7a5c0f3c474f36a8d5ba83c7121ae9da5ea3886f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I forgot to mention this is an A++ branch name. Excellent work. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removes most of the remaining usages of the deprecated
go-autorest
package in unit tests.Which issue(s) this PR fixes:
Refs #2974
Special notes for your reviewer:
This leaves only the somewhat trickier use of
autorest.Environment
in the codebase, which we can address separately.TODOs:
Release note: