Skip to content

Conversation

@shraddhabang
Copy link
Collaborator

Acknowledge-by and Initial POC done by: Taylor Smith [taylorsmithgg]
#4314

Issue

Fixes #1572

Description

  • New Controller: Added globalaccelerator_controller.go with basic framework of reconciliation logic, finalizer management, and error handling. Follows established controller patterns.

  • Configuration: Added controller-specific config options and feature gate support

  • Metrics: Integrated AGA-specific metrics collection and reconcile tracking

  • Events: Added GlobalAccelerator event reasons for operational visibility

  • RBAC: Updated permissions for GlobalAccelerator resources in both Kubernetes manifests and Helm charts

  • Integration: Registered controller with manager and added proper scheme registration

Testing

  1. Tested that the controller is getting events for AGA creation and deletions.
  2. Feature gate is working as expected

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shraddhabang, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [shraddhabang,zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shraddhabang shraddhabang requested a review from shuqz October 16, 2025 18:20
@shuqz
Copy link
Collaborator

shuqz commented Oct 16, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6a05030 into kubernetes-sigs:main Oct 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Global LoadBalancer support

4 participants