-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Default Value for Chart defaultSSLPolicy because of Update TLS to version 1.2 or higher
#4055
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: riita10069 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update TLS to version 1.2 or higher
@@ -259,7 +259,7 @@ tolerateNonExistentBackendService: | |||
tolerateNonExistentBackendAction: | |||
|
|||
# defaultSSLPolicy specifies the default SSL policy to use for TLS/HTTPS listeners | |||
defaultSSLPolicy: | |||
defaultSSLPolicy: ELBSecurityPolicy-TLS13-1-3-2021-06 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quoted from doc
- The
ELBSecurityPolicy-TLS13-1-2-2021-06
policy is the default security policy for HTTPS listeners created using theAWS Management Console
. - The
ELBSecurityPolicy-2016-08
policy is the default security policy for HTTPS listeners created using theAWS CLI
.
Keep in mind that changing the values.yaml
could be a breaking change for those who don't set values while helm install/upgrade.
FYI, default of the defaultSSLPolicy
will be set via flag here,
where the default definition could be found at
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. This change is particularly dangerous. If you wish to enforce SSL policy enforcement, I would suggest a feature that sets the default at the controller level using feature flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a controller flag default-ssl-policy
which customers can use to set their desired policy. The controller level default is ELBSecurityPolicy-2016-08
which aligns with our CLI behavior mentioned earlier. So I don't think this is a valid change as this could break existing customer.
Issue
#4054
Description
To ensure compliance with modern security standards and to mitigate vulnerabilities associated with older TLS versions, we need to configure the Application Load Balancer (ALB) to use an SSL policy that enforces TLS 1.2 or higher. This change aligns with industry best practices and AWS recommendations.
Requirements:
Update the ALB's SSL policy to one that supports only TLS 1.2 and TLS 1.3.
Recommended policies include:
ELBSecurityPolicy-TLS13-1-2-2021-06
Verify that the updated policy disables support for deprecated protocols such as TLS 1.0 and TLS 1.1.
Ensure compatibility with all client systems accessing the ALB.
Justification:
Security Compliance: Industry standards such as PCI DSS, NIST, and others mandate the use of secure protocols like TLS 1.2 or higher.
AWS Recommendations: AWS documentation recommends using the latest predefined security policies, such as ELBSecurityPolicy-TLS13-1-2-2021-06, which support TLS 1.3 and are backward-compatible with TLS
Mitigation of Vulnerabilities: Older protocols (TLS 1.0/1.1) are considered insecure and have been deprecated by most modern browsers and operating systems.
https://trendmicro.com/cloudoneconformity/knowledge-base/aws/ELBv2/security-policy.html
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯