Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CONTRIBUTING.md #955

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

rexagod
Copy link
Collaborator

@rexagod rexagod commented Jul 17, 2024


* **Ensure the bug was not already reported** by searching on GitHub under [Issues](https://github.com/kubernetes-monitoring/kubernetes-mixin/issues).

* If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/kubernetes-monitoring/kubernetes-mixin/issues/new). Be sure to include a **title and clear description**, as much relevant information as possible, and a **`jsonnet` snippet**, if applicable, as well as an optional **visual sample** demonstrating the expected behavior that is not occurring.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also for new features add:

  • "Is your feature request related to a problem? Please describe."
  • "Describe the solution you'd like"
  • "Describe alternatives you've considered" (optional)
  • "Additional context" (optional

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, people don't describe the actual problem they have and just push for solution, which makes it very hard to review

@rexagod rexagod requested a review from povilasv July 24, 2024 11:14
@povilasv povilasv merged commit 1b71e39 into kubernetes-monitoring:master Aug 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants