Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI) Revert to a previous revision of grafana-builder #922

Merged

Conversation

rgeyer
Copy link
Contributor

@rgeyer rgeyer commented Apr 29, 2024

This commit of jsonnet-libs/grafana-builder introduced an import which is not used, and not included in a jsonnetfile.json for the library, which is causing CI issues here.

As part of #898 we'll eventually remove grafana-builder entirely, but for now this will allow CI linting to complete successfully.

Note that this PR does not resolve a few other linting issues found when running jsonnet-lint, those are addressed as drive-by fixes in #918. Thus, when this PR, and #918 are both merged, the master branch should build cleanly.

@povilasv povilasv merged commit 2378886 into kubernetes-monitoring:master Apr 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants