fix(dashboards): Port multi-cluster dashboard to new grafonnet library #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Lang <[email protected]>
povilasv
approved these changes
Apr 9, 2024
|
Thank you |
v-zhuravlev
reviewed
Apr 11, 2024
Comment on lines
+301
to
+305
| g.util.grid.wrapPanels(panels.highlights, panelWidth=4, panelHeight=3, startY=0) | ||
| + g.util.grid.wrapPanels(panels.cpuUsage, panelWidth=24, panelHeight=7, startY=1) | ||
| + g.util.grid.wrapPanels(panels.cpuQuota, panelWidth=24, panelHeight=7, startY=2) | ||
| + g.util.grid.wrapPanels(panels.memoryUsage, panelWidth=24, panelHeight=7, startY=3) | ||
| + g.util.grid.wrapPanels(panels.memoryRequests, panelWidth=24, panelHeight=7, startY=4) |
There was a problem hiding this comment.
you could provide whole array of panels into single wrapPanels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the
Kubernetes / Compute Resources / Multi-Clusterdashboard over to the new grafonnet library in order to support Grafana 11.Relates to:
In addition:
grafanaDashboardIDsreferences in order to provide consistent data linksScreenshot of updated dashboard running:
Test procedure:
Add a dashboard provisioning YAML file to your Grafana instance, e.g.
provisioning/dashboards/dashboards.yaml:Mount the
dashboards_outto your docker container, e.g. viadocker-compose.yaml:- /path/to/kubernetes-mixin/dashboards_out:/var/lib/grafana/dashboards/kubernetes-mixinInstall the kubernetes-mixin repo deps:
go install github.com/jsonnet-bundler/jsonnet-bundler/cmd/jb@latest brew install jsonnet cd kubernetes-mixin jb installIterate and build the mixin:
Grafana will automatically re-provision the dashboards every 10 seconds.