Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: Fix deeplinks #884

Closed
wants to merge 2 commits into from
Closed

Dashboards: Fix deeplinks #884

wants to merge 2 commits into from

Conversation

jkroepke
Copy link
Contributor

Since Grafana has a new Table panel (since Grafana 7), the deeplink $__cell isn't working anymore. (at least in Grafana 10.2)

Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke jkroepke marked this pull request as ready for review November 21, 2023 08:49
@jkroepke
Copy link
Contributor Author

Without this, deeplinks are not working

image

@jkroepke
Copy link
Contributor Author

jkroepke commented Dec 8, 2023

@povilasv could you take a look here?

@povilasv
Copy link
Contributor

povilasv commented Dec 8, 2023

I think we might need to support older versions of grafana, so we cannot merge this. Also see this #864 (comment)

@jkroepke
Copy link
Contributor Author

jkroepke commented Dec 8, 2023

I would suggest to drop old grafana versions. Maintain multiple grafana version is a high maintenance effort and its discussable if its worth.

I would drop old version. Old Grafana users can still use old revisions.

In background, kubernetes-mixin depends on the old Table panel which is deprecated for a long time. In thoery, support for that old panel is already gone. Grafana do a auto-converation from old panel to the new one.

Once grafana drops the auto-converation, the whole kubernetes-mixin is useless.

@povilasv
Copy link
Contributor

I agree. But I think instead of doing small fixes like this, let's just refactor to new grafonnet. I think we can add README that x release only supports newest grafana and that's it.

@jkroepke
Copy link
Contributor Author

jkroepke commented Mar 4, 2024

I will close this for now. Since it does not work on grafana instances with, if auto-migration of panel is not enabled.

However, Grafana 11 removed support for old table panel. In near future, the dashboard might be outdated anyways.

@jkroepke jkroepke closed this Mar 4, 2024
@jkroepke jkroepke deleted the fix/deeplinks branch March 4, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants