Add cluster label to CPUThrottling alert when showMultiCluster enabled #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: n888 <[email protected]>
Closed
|
Is this repo maintained any longer? Any reason this PR has not been reviewed for months? It's simple and a lot of people are in need of it. |
|
We would benefit from this contribution as well. Pinging @povilasv as he is active in this space. Can you PTAL? |
povilasv
reviewed
Oct 30, 2023
|
Sorry for late review, added a comment other than that LGTM. |
|
Thanks for review 👍 Updated to remove the check |
|
FYI CI is failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: It would help to know from which cluster a pod is throwing a CPUThrottling alert, when showMultiCluster is enabled.