Basic cron job alerts. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @StevenACoffman |
|
For other people's reference, this is the blog article and the rules are here in this repository |
|
Nice. This might be a good opportunity to add descriptions of these to the runbook page and link them, if it's convenient. Otherwise, we don't need to hold this up waiting for perfection. |
brancz
reviewed
Jun 18, 2018
alerts/apps_alerts.libsonnet
Outdated
| severity: 'warning', | ||
| }, | ||
| annotations: { | ||
| description: 'CronJob {{ $labels.namespaces }}/{{ $labels.cronjob }} is taking more than 1h to complete.', |
There was a problem hiding this comment.
We use message everywhere else, either we make this configurable in the first place or just stick with message.
There was a problem hiding this comment.
Yeah lets stick with message for now, this was a mistake.
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
brancz
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24; haven't tried the more advanced alerts mentioned in the blog yet.
Signed-off-by: Tom Wilkie [email protected]