Revert "Add min go runtime to be 1.23 and add godebug winsymlink=0" #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/feature
mauriciopoppe
force-pushed
the
revert-go-1-23
branch
from
73f1990 to
1e8cff5
Compare
|
Blocked by kubernetes/kubernetes#130203. |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
1 similar comment
|
/retest |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
mauriciopoppe
force-pushed
the
revert-go-1-23
branch
3 times, most recently
from
aa39705 to
89760a5
Compare
k8s-ci-robot
added
size/M
This reverts commit ab5cffa.
mauriciopoppe
force-pushed
the
revert-go-1-23
branch
from
89760a5 to
058c869
Compare
|
Hey Andy, could you please review this revert? I'm going to release 1.2.1 with go 1.22 support first. Moving to go1.23 + compat fixes will be part of a future PR. /cc @andyzhangx |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 26, 2025
…369-upstream-release-1.2 Automated cherry pick of #369: Revert "Add min go runtime to be 1.23 and add godebug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This reverts commit ab5cffa. While this added go 1.23 support with compat flags we're still learning what changes might be needed in kubelet to make the windows storage privileged ops to work with go 1.23 without compat flags.
Ref #361
Does this PR introduce a user-facing change?:
/cc @msau42 @sunnylovestiramisu