Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate volume API group to library model #240

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Migrate volume API group to library model #240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6602735
feat: migrate volume API group to library model
alexander-ding Oct 10, 2022
1e7bd18
chore: move volumeInit to utils
alexander-ding Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions integrationtests/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,17 @@ func diskInit(t *testing.T) (*VirtualHardDisk, func()) {
return vhd, cleanup
}

// sizeIsAround returns true if the actual size is around the expected size
// (considers the fact that some bytes were lost)
func sizeIsAround(t *testing.T, actualSize, expectedSize int64) bool {
// An upper bound on the number of bytes that are lost when creating or resizing a partition
var volumeSizeBytesLoss int64 = (20 * 1024 * 1024)
var lowerBound = expectedSize - volumeSizeBytesLoss
var upperBound = expectedSize
t.Logf("Checking that the size is inside the bounds: %d < (actual) %d < %d", lowerBound, actualSize, upperBound)
return lowerBound <= actualSize && actualSize <= upperBound
}

func pathExists(path string) (bool, error) {
_, err := os.Stat(path)
if err == nil {
Expand Down
Loading