feat: Add retention policy for available releases cleanup#37
Merged
LittleChimera merged 8 commits intomainfrom Jan 3, 2026
Merged
feat: Add retention policy for available releases cleanup#37LittleChimera merged 8 commits intomainfrom
LittleChimera merged 8 commits intomainfrom
Conversation
Contributor
LittleChimera
commented
Dec 26, 2025
LittleChimera
commented
- Change default history limit from 5 to 10
- Add cleanup of old available releases when history is full
- Implement retention policy with three criteria (OR logic):
- Keep all releases from the lowest history entry index to the end
- Keep all releases created within the last week (7 days)
- Keep at least 30 releases minimum
- Keep the maximum number of releases that satisfies any criterion
- Add comprehensive tests for retention policy
- Change default history limit from 5 to 10 - Add cleanup of old available releases when history is full - Implement retention policy with three criteria (OR logic): 1. Keep all releases from the lowest history entry index to the end 2. Keep all releases created within the last week (7 days) 3. Keep at least 30 releases minimum - Keep the maximum number of releases that satisfies any criterion - Add comprehensive tests for retention policy
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 3. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
- Add AvailableReleasesRetentionDays field to RolloutSpec (default: 7 days) - Add AvailableReleasesMinCount field to RolloutSpec (default: 30 releases) - Update cleanup function to use configurable values instead of hardcoded constants - Update function documentation to reflect configurability
- Remove hacky duplicate tag scenario that can't occur in reality - Rewrite test to verify cleanup keeps releases from lowest history entry index - Set proper timestamps and minimum retention to allow cleanup to work - Let controller naturally build AvailableReleases instead of manually setting it - Add debug logging to controller for troubleshooting (can be removed if needed)
- Initialize AvailableReleases upfront with all versions and timestamps - Use for loop to deploy versions instead of manual per-version deployment - Restore timestamps once before final deployment instead of after each one - Cleaner and more maintainable test code
- Remove manual ImagePolicy 0.1.0 setup from tests that use loops - Convert manual deployments to loops where appropriate - Cleaner and more consistent test code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.