Replace BakeStatusPending with BakeStatusDeploying#35
Conversation
- Rename BakeStatusPending constant to BakeStatusDeploying in API types - Update all references from Pending to Deploying in controller logic - Update test assertions and descriptions to use Deploying status - Update status messages and event names to reflect Deploying status
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| const ( | ||
| BakeStatusPending = "Pending" | ||
| BakeStatusDeploying = "Deploying" |
There was a problem hiding this comment.
Breaking change: existing "Pending" status resources become orphaned
The constant BakeStatusPending was renamed to BakeStatusDeploying but the string value also changed from "Pending" to "Deploying". Existing Rollout resources in Kubernetes with BakeStatus: "Pending" stored in etcd will no longer be recognized by the controller's switch statements that now check for "Deploying". This causes handleBakeTime to be skipped for those resources, potentially leaving them stuck in an unrecognized state without proper bake time handling. To safely rename while maintaining backward compatibility, the value should remain "Pending" or migration logic is needed.
Additional Locations (2)
1 participant
Note
Standardizes bake pre-start phase terminology.
BakeStatusPendingwithBakeStatusDeployinginrollout_types.go.Deployingequivalently to previousPendingin bake-time evaluation, blocking, cancellation, and transitions toInProgress; update status summaries and initial bake state toDeploying; change eventBakeTimePendingtoBakeTimeDeploying.Deployinginstead ofPendingacross bake gating, release candidate population, cancellation, timeouts, and failure paths.Written by Cursor Bugbot for commit 88c8bb5. This will update automatically on new commits. Configure here.